pivotal-jbarrett commented on a change in pull request #639:
URL: https://github.com/apache/geode-native/pull/639#discussion_r475313465



##########
File path: clicache/src/CacheFactory.cpp
##########
@@ -70,14 +71,12 @@ namespace Apache
           pdxReadSerialized = nativeCache->getPdxReadSerialized();
 
           Log::SetLogLevel(static_cast<LogLevel>(native::Log::logLevel( )));
-          native::createAppDomainContext = 
&Apache::Geode::Client::createAppDomainContext;
-
 
           DistributedSystem::ManagedPostConnect(cache);
           DistributedSystem::registerCliCallback();
           auto&& cacheImpl = 
CacheRegionHelper::getCacheImpl(nativeCache.get());
           cacheImpl->getSerializationRegistry()->setPdxTypeHandler(new 
ManagedPdxTypeHandler());
-                 
cacheImpl->getSerializationRegistry()->setDataSerializableHandler(new 
ManagedDataSerializableHandler());
+                     
cacheImpl->getSerializationRegistry()->setDataSerializableHandler(new 
ManagedDataSerializableHandler());

Review comment:
       Looks like formatting got out of wack with your Visual Studio. Can you 
back out the change on this lineZ or better yet make the indent match the rest 
of the file:




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to