jchen21 commented on a change in pull request #5469:
URL: https://github.com/apache/geode/pull/5469#discussion_r476648457
##########
File path:
geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/json/QueryResultFormatterTest.java
##########
@@ -117,15 +119,19 @@ public void testPrimitives() throws Exception {
QueryResultFormatter stringResult = new
QueryResultFormatter(100).add(RESULT, "String");
checkResult(stringResult,
"{\"result\":[[\"java.lang.String\",\"String\"]]}");
+ Date date = new Date(0);
+ String expectedString =
+ new
SimpleDateFormat(QueryResultFormatter.DATE_FORMAT_PATTERN).format(date);
QueryResultFormatter javaDateResult =
- new QueryResultFormatter(100).add(RESULT, new java.util.Date(0));
+ new QueryResultFormatter(100).add(RESULT, date);
checkResult(javaDateResult,
-
"{\"result\":[[\"java.util.Date\",\"1970-01-01T00:00:00.000+0000\"]]}");
+ "{\"result\":[[\"java.util.Date\",\"" + expectedString + "\"]]}");
+ java.sql.Date sqlDatee = new java.sql.Date(0);
Review comment:
Is `sqlDatee` a typo?
##########
File path: boms/geode-all-bom/src/test/resources/expected-pom.xml
##########
@@ -67,6 +67,12 @@
<version>2.9.8</version>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.datatype</groupId>
Review comment:
Can you point me where this new dependency is used in the test? I don't
see it is used in the tests of this pull request.
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/json/AbstractJSONFormatter.java
##########
@@ -94,6 +94,8 @@ public AbstractJSONFormatter(int maxCollectionElements, int
serializationDepth,
// register the custom module
mapper.registerModule(mapperModule);
+ // to support jdk8 java.time if jackson-datatype-jsr310 is included in the
classpath
Review comment:
Can you elaborate a bit why `jackson-datatype-jsr310` is needed? I am
not sure why it is necessary to add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
