echobravopapa commented on a change in pull request #641:
URL: https://github.com/apache/geode-native/pull/641#discussion_r477343512
##########
File path: clicache/test2/Tests2.cs
##########
@@ -123,7 +123,24 @@ public void RegisterPdxType()
Assert.False(_pdxDelegate2Called);
}
- private class DummyPdxSerializer : IPdxSerializer
+ [Fact]
+ public void SetSniProxy()
+ {
+ PoolFactory poolFactory = _cacheOne.GetPoolFactory()
+ .AddLocator("localhost", 10334);
+
+ poolFactory.SetSniProxy("haproxy", 7777);
Review comment:
I'd like to see this right after `AddLocator` in the typical builder
pattern look...
##########
File path: cppcache/src/Pool.cpp
##########
@@ -45,6 +45,9 @@ std::chrono::milliseconds Pool::getReadTimeout() const {
return m_attrs->getReadTimeout();
}
+std::string Pool::getSniProxyHost() const { return m_attrs->getSniProxyHost();
}
Review comment:
formatting looks off here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
