pivotal-jbarrett commented on a change in pull request #642:
URL: https://github.com/apache/geode-native/pull/642#discussion_r477658402
##########
File path: cppcache/src/ThinClientPoolDM.cpp
##########
@@ -1428,10 +1428,12 @@ GfErrType ThinClientPoolDM::sendSyncRequest(
}
excludeServers.insert(ServerLocation(ep->name()));
if (error == GF_IOERR) {
- auto sl = std::make_shared<BucketServerLocation>(ep->name());
- LOGINFO("Removing bucketServerLocation %s due to GF_IOERR",
- sl->toString().c_str());
- m_clientMetadataService->removeBucketServerLocation(sl);
+ if (m_clientMetadataService != nullptr) {
Review comment:
The one style thing I would point out is that `std::unique_ptr`
explicitly converts to `true` if set or `false` if is `nullptr` specifically
for the usage in if statements like this.
```c++
if (m_clientMetadataService) {
m_clientMetadataService->doSomething();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
