albertogpz opened a new pull request #5486:
URL: https://github.com/apache/geode/pull/5486


   …ssible
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   
   This Draft PR tries to provide an alternative solution to the ones offered 
in RFC 
https://cwiki.apache.org/confluence/display/GEODE/Avoid+the+queuing+of+dropped+events+by+the+primary+gateway+sender+when+the+gateway+sender+is+stopped.
   
   The high level idea consists of instead of trying not to store dropped 
events in tmpDroppedEvents to later send batch removal messages when the 
primary gateway sender is not started. Instead try to send the batch removal 
message when the event to be dropped is received. That way, when the sender is 
stopped for a long time and there are events coming, the memory of the 
AbstractGatewaySender will not grow with entries in the tmpDroppedEvents member.
   
   In order to send the batch removal message directly, the eventProcessor for 
the AbstractGatewaySender must have been created. If it is not yet created 
because the sender was created with manual start set to true, while receiving 
events to be dropped, they will be stored in tmpDroppedEvents as there is no 
other choice. Nevertheless, in order to consume less memory, the event stored 
will be a simplified event containing only the necessary information to handle 
it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to