jhutchison commented on a change in pull request #5526:
URL: https://github.com/apache/geode/pull/5526#discussion_r492821512



##########
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/netty/Command.java
##########
@@ -183,8 +184,16 @@ public boolean isOfType(RedisCommandType type) {
   }
 
   public String wrongNumberOfArgumentsError() {
-    return String.format("wrong number of arguments for '%s' command",
-        getCommandType().toString().toLowerCase());
+    String result;
+
+    if (getCommandType().equals(RedisCommandType.INFO)) {

Review comment:
       yeah, we discussed that same thing.  I think we both saw this point but 
decided not to make the change because we had just finished doing it the other 
way.  Anyway, just pushed a commit that implements it the way we originally 
discussed (with the parameter being passed in when the command is declared in 
the RedisCommandTypes file).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to