jdeppe-pivotal commented on a change in pull request #5584:
URL: https://github.com/apache/geode/pull/5584#discussion_r499043152
##########
File path:
geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/key/RenameNativeRedisAcceptanceTest.java
##########
@@ -14,30 +14,25 @@
*/
package org.apache.geode.redis.internal.executor.key;
-import java.util.Random;
-
-import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Test;
-import redis.clients.jedis.Jedis;
import org.apache.geode.NativeRedisTestRule;
-public class RenameNativeRedisAcceptanceTest extends RenameIntegrationTest {
+public class RenameNativeRedisAcceptanceTest extends
AbstractRenameIntegrationTest {
+
@ClassRule
public static NativeRedisTestRule redis = new NativeRedisTestRule();
- @BeforeClass
- public static void setUp() {
- rand = new Random();
- jedis = new Jedis("localhost", redis.getPort(), 10000000);
- jedis2 = new Jedis("localhost", redis.getPort(), 10000000);
- jedis3 = new Jedis("localhost", redis.getPort(), 10000000);
+ @Override
+ public int getPort() {
+ return redis.getPort();
}
@Override
@Test
@Ignore("native redis does implement renamenx")
public void renamenxIsUnimplemented() {}
+
Review comment:
I decided to just delete the test. I created a story for us to implement
`RENAMENX`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
