moleske opened a new pull request #668:
URL: https://github.com/apache/geode-native/pull/668


   After watch @gaussianrecurrence have some feed back about Windows being 
broken in the PR, I thought I'd share what I use to try to cover the bases.  
This uses [GitHub 
Actions](https://docs.github.com/en/free-pro-team@latest/actions) to run tests 
on Ubuntu 16.04 & 18.04 and Windows 2016 with VS2017 and Windows 2019 with 
VS2019.  It is slow and prone to flakiness, but it is easy to rerun.  Also not 
all builds work on VS2019 so those weren't added.  It also doesn't run 
acceptance test nor build with clang at the moment.  It does the rat and clang 
format checks though.
   
   The software available on the GitHub workers is 
[here](https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-software).
  There is the possibility to use [own 
workers](https://docs.github.com/en/free-pro-team@latest/actions/hosting-your-own-runners)
 which could be more powerful, but I didn't look at that.
   
   I don't actually expect to merge this, as Geode seems all in on Concourse.  
I like me some Concourse, but I don't think it is easy to collaborate on 
Concourse for either Geode or Geode Native.  It is especially hard to test 
changes yourself if you don't have a concourse lying around with all the 
secrets you want.
   
   If you want to see this in action, you can look at the [PRs I opened against 
my fork](https://github.com/moleske/geode-native/pulls) of the repo to see what 
success and flakiness appears.  To see the run of this PR branch, check [this 
out](https://github.com/moleske/geode-native/runs/1212763980).  If you want to 
see my original setup, which includes Mac (which is currently broken for 
reasons I don't understand) and a workflow of things I think should work but 
don't, you can check out my [test actions 
branch](https://github.com/moleske/geode-native/tree/test-actions) and the 
[results of that 
running](https://github.com/moleske/geode-native/actions?query=branch%3Atest-actions).
   
   Feel free to push changes to this branch to try things out.  Currently it 
does not save error logs or run with `-VV` for details, but of which might be 
useful.  GitHub allows the [uploading of 
artifacts](https://docs.github.com/en/free-pro-team@latest/actions/guides/storing-workflow-data-as-artifacts)
 to runs, so it would be possible on failure to upload logs.  I only tried 
uploading the entire build, but the entire build is way to big and often timed 
out on me.  But a few log files seem like it should work.  Might also be neat 
if there was a way to pass a built artifact around rather than what it current 
does of building it for each test.  Regardless, this seemed like a good first 
step to make progress on this front rather than try to port the Geode Concourse 
setup over.  Maybe Concourse can be used for some other publishing steps, or 
maybe this will just not be used and provide inspiration on other ways to 
organize.  I think this would have helped @gaussianrecurrence find some o
 f the Windows problems before @pdxcodemonkey found them on his private CI he 
has.  I also believe this will help us spend less time on CI since I think a 
fair amount of work goes into maintaining the running Concourse for Geode, 
which would free to people to work on other problems.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to