aaronlindsey commented on a change in pull request #5598:
URL: https://github.com/apache/geode/pull/5598#discussion_r500614767
##########
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
##########
@@ -349,9 +349,9 @@ public boolean join() throws MemberStartupException {
&& state.possibleCoordinator.equals(this.localAddress)) {
// if we haven't contacted a member of a cluster maybe this node
should
// become the coordinator.
- if (state.joinedMembersContacted <= 0 && (now >=
locatorGiveUpTime) &&
- (tries >= minimumRetriesBeforeBecomingCoordinator ||
- state.locatorsContacted >= locators.size())) {
+ if (state.joinedMembersContacted <= 0 && (now >= locatorGiveUpTime
&&
+ tries >= minimumRetriesBeforeBecomingCoordinator) ||
+ state.locatorsContacted >= locators.size()) {
Review comment:
The new logic in the latest commit makes sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
