[GitHub] [geode] sabbey37 commented on a change in pull request #5639: GEODE-8627: Redis not unsubscribing and punsubscribing correctly when no channel/pattern provided

[GitBox]

sabbey37 commented on a change in pull request #5639:
URL: https://github.com/apache/geode/pull/5639#discussion_r509288983



##########
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/pubsub/PubSubImpl.java
##########
@@ -140,18 +139,17 @@ public long punsubscribe(GlobPattern pattern, Client 
client) {
   }
 
   @Override
-  public List<byte[]> findSubscribedChannels(Client client) {
+  public List<byte[]> findSubscriptionsNames(Client client) {
     return subscriptions.findSubscriptions(client).stream()
-        .map(Subscription::getChannelName)
-        .filter(Objects::nonNull)
+        .map(Subscription::getSubscriptionName)
         .collect(Collectors.toList());
   }
 
   @Override
-  public List<byte[]> findSubscribedPatterns(Client client) {
+  public List<byte[]> findSubscriptionsNames(Client client, Subscription.Type 
type) {
     return subscriptions.findSubscriptions(client).stream()
-        .map(Subscription::getPatternName)
-        .filter(Objects::nonNull)
+        .filter(s -> s.getType().equals(type))

Review comment:
       Good to know! I'll update it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org