dschneider-pivotal commented on pull request #5665: URL: https://github.com/apache/geode/pull/5665#issuecomment-716697054
@bschuchardt when you said to move the buffer-clearing to readAck did you mean the code in notifyHandshakeWaiter that sets the position and limit to 0 if SSL? If so I don't understand what that has todo with readAck. notifyHandshakeWaiter is called to notify the thread that is stuck in waitForHandshake that it no longer needs to wait. I don't understand why in SSL we need to clear the buffer before doing this (we thought you might know why) but it does not seem to be connected with reading a direct ack which is what readAck does. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
