bschuchardt commented on a change in pull request #5669:
URL: https://github.com/apache/geode/pull/5669#discussion_r512776334
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java
##########
@@ -846,7 +846,14 @@ private boolean setServerNames(SSLParameters
modifiedParams, HostAndPort addr) {
// ignore - we'll see what happens with endpoint validation using a
numeric address...
}
}
- serverNames.add(new SNIHostName(hostName));
+ try {
+ serverNames.add(new SNIHostName(hostName));
+ } catch (Exception ex) {
Review comment:
I'm not sure that's actually necessary though - ConnectionFactoryImpl
already catches the exception this PR is guarding and logs it. Do you have a
failure that this PR is fixing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
