sabbey37 commented on a change in pull request #5678:
URL: https://github.com/apache/geode/pull/5678#discussion_r513724885
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/RedisStats.java
##########
@@ -171,13 +180,92 @@ public void endCommand(RedisCommandType command, long
start) {
}
public void addClient() {
+ connectionsReceived.incrementAndGet();
+ connectedClients.incrementAndGet();
stats.incLong(clientId, 1);
Review comment:
The `clientID` statistic is actually the same as `connectedClients`. We
could make the `getClients()` method public and just use that (unless there's a
reason we shouldn't make it public)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
