pivotal-jbarrett commented on a change in pull request #682:
URL: https://github.com/apache/geode-native/pull/682#discussion_r516176141
##########
File path: clicache/src/DataInput.cpp
##########
@@ -878,8 +877,6 @@ namespace Apache
void DataInput::Cleanup()
{
Review comment:
If this method is empty perhaps we can remove it?
##########
File path: clicache/src/DataInput.hpp
##########
@@ -663,7 +664,7 @@ namespace Apache
m_buffer =
const_cast<System::Byte*>(nativeptr->currentBufferPosition());
if ( m_buffer != NULL) {
m_bufferLength =
static_cast<decltype(m_bufferLength)>(nativeptr->getBytesRemaining());
- }
+ }
Review comment:
Some strange formatting mess here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
