pivotal-jbarrett commented on a change in pull request #686:
URL: https://github.com/apache/geode-native/pull/686#discussion_r518904843
##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -144,9 +146,9 @@ void verifyMetadataWasRemovedAtFirstError() {
}
}
}
- ASSERT_TRUE((timeoutErrors == metadataRemovedDueToTimeout) &&
- (ioErrors == metadataRemovedDueToIoErr) &&
- (metadataRemovedDueToTimeout != metadataRemovedDueToIoErr));
+ ASSERT_EQ(timeoutErrors, metadataRemovedDueToTimeout);
Review comment:
Alternatively, if you want to see the results of all three checks and
fail if any of them fail you can use `EXPECT_*` macros. There are also more
options for expecting and asserting in the `gmock` module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
