sabbey37 commented on a change in pull request #5678:
URL: https://github.com/apache/geode/pull/5678#discussion_r519924460
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/RedisStats.java
##########
@@ -82,6 +104,28 @@
expirationTimeId = type.nameToId("expirationTime");
}
+ public RedisStats(StatisticsFactory factory, StatisticsClock clock) {
+ this(factory, "redisStats", clock);
+ }
+
+ public RedisStats(StatisticsFactory factory, String textId, StatisticsClock
clock) {
+ stats = factory == null ? null : factory.createAtomicStatistics(type,
textId);
+ this.clock = clock;
+ this.START_TIME_IN_NANOS = this.clock.getTime();
+ perSecondExecutor = startPerSecondUpdater();
+ }
+
+ public void clearAllStats() {
Review comment:
Not necessary to do this in this PR unless you're making other changes
as well, but it might be a good idea to make this method `protected` instead of
public and mark it as `@VisibleForTesting`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
