pivotal-jbarrett commented on pull request #691: URL: https://github.com/apache/geode-native/pull/691#issuecomment-726158242
@gaussianrecurrence on further inspection I have concerns about the methods being added to to the internal region since they only apply to partitioned regions. I am also concerned about the thread safety of changing the resolver after the region is initialized. I have added @pdxcodemonkey as a reviewer because I don't have the bandwidth right now to investigate this. I would also suggest you look at the Java implementation for inspiration. Can the Java version mutate the partition resolver? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
