pivotal-jbarrett commented on a change in pull request #688:
URL: https://github.com/apache/geode-native/pull/688#discussion_r522344656
##########
File path: cppcache/src/ExceptionTypes.cpp
##########
@@ -23,30 +23,61 @@
#include "ErrType.hpp"
#include "util/Log.hpp"
-namespace apache {
-namespace geode {
-namespace client {
-
-void setThreadLocalExceptionMessage(std::string exMsg);
-const std::string& getThreadLocalExceptionMessage();
-
-static std::map<GfErrType, std::function<void(std::string, std::string&,
- GfErrType, std::string)>>
- error_map;
+namespace {
+
Review comment:
Wait, why did you pull this out of the namespace and then import all
these exceptions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
