echobravopapa commented on a change in pull request #5744:
URL: https://github.com/apache/geode/pull/5744#discussion_r522459797
##########
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorIntegrationTest.java
##########
@@ -137,6 +137,18 @@ public void startedLocatorHasLocator() throws IOException {
assertThat(InternalLocator.hasLocator()).isTrue();
}
+ @Test
Review comment:
I'm not saying this test is invalid, but it doesn't validate the fix
below in `InternalLocator` i.e. if one comments out that code the test still
passes...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
