gaussianrecurrence commented on pull request #700: URL: https://github.com/apache/geode-native/pull/700#issuecomment-733945720
There's one thing I am not sure about if it's the right call and that's having added a modification of GenerateExportHeaders. This is necessary in order to specify the visibility flags to the factory function added to cpp-integration-test for testing purposes. Thing is GenerateExportHeaders does not support executables, so that's the rationale behind ExecutableExportHeader.cmake Please let me know what you think about it and if you think there might be a better alternative. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
