upthewaterspout commented on pull request #104:
URL: https://github.com/apache/geode-examples/pull/104#issuecomment-733948078


   > @upthewaterspout i have done the changes as mentioned in point 1 and 2. 
However pull request checks are failing as i have used HttpClient api of java 
11. Is java 11 not supported?. I can reuse HttpURLConnection instead of 
HttpClient but wanted to confirm if this something do with Travis and LGTM 
analysis.
   
   It does look like we've left the examples using java 8 for Travis. 
Personally, I think it would be fine if we change the minimum version for the 
examples to be java 11. 
   
   We should probably do that with a separate pr and merge that first. I'm on 
Thanksgiving holiday here right now but I can bring that up next week if you 
like.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to