pivotal-jbarrett commented on pull request #706: URL: https://github.com/apache/geode-native/pull/706#issuecomment-741277312
> The fix should be made in the Geode server sources at make BaseCommand.shouldMasqueradeForTx consistent with all other checks against `NOTX`. In all other checks explicit equality is checked, not for greater or less than. Pointed out offline to me, this won't fix the original issue either since `0 != NOTX` is `true` too. 🤦 I really think we should understand why `0` was used here and on both the C++ and Java versions of these messages. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
