nabarunnag commented on a change in pull request #5821:
URL: https://github.com/apache/geode/pull/5821#discussion_r539157930
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java
##########
@@ -638,6 +639,17 @@ protected boolean basicHandlePrimaryDestroy(final EventID
eventId) {
ew.event.release();
statistics.incUnprocessedEventsRemovedByPrimary();
return true;
+ } else if (addToUnprocessedTokens) {
+ // Secondary event may not have arrived
+ Long mapValue =
+ Long.valueOf(System.currentTimeMillis() +
AbstractGatewaySender.TOKEN_TIMEOUT);
+ Long oldv = this.unprocessedTokens.put(eventId, mapValue);
+ if (oldv == null) {
+ statistics.incUnprocessedTokensAddedByPrimary();
+ } else {
+ // its ok for oldv to be non-null
+ // this shouldn't happen anymore @todo add an assertion here
+ }
Review comment:
Same logic as in basicHandlePrimaryEntry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
