dschneider-pivotal commented on pull request #5818: URL: https://github.com/apache/geode/pull/5818#issuecomment-742046914
@jdeppe-pivotal for async ops you can always have the test wait to confirm the stat is updated right after close returns. This tells you the async close operation has completed. I don't see how the reset helps (it with async closes is probably the cause of the stat going negative). It would be better to test the product without adding product code if possible. If you do need to keep it then make sure and mark it for testing only. Also check that it actually resets all the stats (I think at least one was missing). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
