kirklund commented on a change in pull request #5778:
URL: https://github.com/apache/geode/pull/5778#discussion_r542625730
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/FederatingManager.java
##########
@@ -380,8 +384,10 @@ void addMemberArtifacts(InternalDistributedMember member) {
return;
}
- try {
+ FederatingManagerCancelCriterion cancelCriterion =
Review comment:
@jdeppe-pivotal hmm, well now you have me second-guessing the need for
CancelCriterion. Maybe we can get another review before we make more changes on
this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]