albertogpz commented on a change in pull request #5859:
URL: https://github.com/apache/geode/pull/5859#discussion_r545234359
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java
##########
@@ -10219,6 +10219,7 @@ public void initializeStats(long numEntriesInVM, long
numOverflowOnDisk,
long numOverflowBytesOnDisk) {
getDiskRegion().getStats().incNumEntriesInVM(numEntriesInVM);
getDiskRegion().getStats().incNumOverflowOnDisk(numOverflowOnDisk);
+
getDiskRegion().getStats().incNumOverflowBytesOnDisk(numOverflowBytesOnDisk);
Review comment:
I would put this change in a different PR/JIRA as it is about a
different bug.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
##########
@@ -838,11 +838,11 @@ public boolean initialImagePut(final Object key, final
long lastModified, Object
if (result) {
if (oldIsTombstone) {
owner.unscheduleTombstone(oldRe);
- if (newValue != Token.TOMBSTONE) {
Review comment:
How about putting the `lruEntryUpdate(oldRe)` and
`lruEntryCreate(oldRe)`calls inside the `else` for the case in which the value
for the new entry is not a tombstone as follows:
```
...
} else { //newValue != Token.TOMBSTONE
int newSize = owner.calculateRegionEntryValueSize(oldRe);
if (!oldIsTombstone) {
lruEntryUpdate(oldRe);
owner.updateSizeOnPut(key, oldSize, newSize);
} else {
lruEntryCreate(oldRe);
owner.updateSizeOnCreate(key, newSize);
}
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
