pivotal-jbarrett commented on a change in pull request #714: URL: https://github.com/apache/geode-native/pull/714#discussion_r546789006
########## File path: cppcache/integration/test/Position.cpp ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#include "Position.hpp" + +#include <wchar.h> Review comment: Still need these wide char includes? ########## File path: cppcache/integration/test/Position.cpp ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#include "Position.hpp" + +#include <wchar.h> + +#include <cwchar> + +#include <geode/DataInput.hpp> +#include <geode/DataOutput.hpp> + +namespace DataSerializableTest { + +int32_t Position::cnt = 0; + +Position::Position() + : avg20DaysVol(0), + convRatio(0.0), + valueGain(0.0), + industry(0), + issuer(0), + mktValue(0.0), Review comment: I would still like to see more readable variable names. The compiler doesn't care how long the names are? ;) Also we should be following the naming convention adopted by this project for new files. ```C++ ... marketValue_(0.0) ... ``` ########## File path: cppcache/integration/test/PositionKey.hpp ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#ifndef POSITIONKEY_H_ +#define POSITIONKEY_H_ + +#include <string> + +#include <geode/CacheableString.hpp> +#include <geode/DataSerializable.hpp> + +namespace DataSerializableTest { + +using apache::geode::client::CacheableKey; +using apache::geode::client::DataInput; +using apache::geode::client::DataOutput; +using apache::geode::client::DataSerializable; + +class PositionKey : public DataSerializable, public CacheableKey { + private: + int64_t m_positionId; Review comment: Since this is a new class, even if it is copied from some older sources, it should conform to our naming conventions. ```C++ int64_t positionId_; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
