dschneider-pivotal commented on a change in pull request #5855:
URL: https://github.com/apache/geode/pull/5855#discussion_r553615737



##########
File path: CODEOWNERS
##########
@@ -0,0 +1,309 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#-----------------------------------------------------------------
+# CODEOWNERS and .asf.yml - owned by everyone
+#-----------------------------------------------------------------
+CODEOWNERS @apache/geode-committers
+.asf.yml @apache/geode-committers
+ 
+#-----------------------------------------------------------------
+# Serialization
+#-----------------------------------------------------------------
+geode-serialization/**                                            @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/pdx/**                             
@upthewaterspout @dschneider-pivotal
+geode-core/**/org/apache/geode/internal/*                         @bschuchardt 
@Bill
+
+#-----------------------------------------------------------------
+# Membership
+#-----------------------------------------------------------------
+geode-membership/**                                               @bschuchardt 
@Bill
+geode-old-client-support/**                                       @bschuchardt 
@Bill
+geode-tcp-server/**                                               @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/internal/membership/** @bschuchardt 
@Bill
+
+#-----------------------------------------------------------------
+# P2P Messaging
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/tcp/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/internal/direct/**     @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/internal/net/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/net/**                             @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/*                      @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/internal/*             @bschuchardt 
@Bill
+
+#-----------------------------------------------------------------
+# Client/server messaging and cache operations
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/cache/client/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/cache/server/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/internal/cache/client/**           @bschuchardt 
@echobravopapa
+geode-core/**/org/apache/geode/internal/cache/tier/**             @bschuchardt 
@echobravopapa
+
+#-----------------------------------------------------------------
+# Client Queues
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/ha/**               @agingade 
@boglesby
+geode-core/**/org/apache/geode/internal/cache/tier/CacheClient*   @agingade 
@boglesby
+ 
+#-----------------------------------------------------------------
+# Experimental Protobuf based Client/Server
+#-----------------------------------------------------------------
+#geode-experimental-driver/**
+#geode-protobuf/**
+#geode-protobuf-messages/**
+
+#-----------------------------------------------------------------
+# Core Public API packages - Cache, Region, etc.
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/*                                  
@dschneider-pivotal @boglesby
+geode-core/**/org/apache/geode/cache/*                            
@dschneider-pivotal @boglesby
+geode-core/**/org/apache/geode/cache/util/**                      
@dschneider-pivotal @boglesby
+
+#-----------------------------------------------------------------
+# Distributed Locks
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/distributed/internal/locks/**      @kirklund 
@dschneider-pivotal
+
+#-----------------------------------------------------------------
+# Core region implementations and plumbing
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/*                   @nabarunnag 
@DonalEvans @jchen21
+
+#-----------------------------------------------------------------
+# Region entry management
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/entries/**          
@dschneider-pivotal @sabbey37
+geode-core/**/org/apache/geode/internal/cache/region/entry/**     
@dschneider-pivotal @sabbey37
+geode-core/**/org/apache/geode/internal/cache/map/**              
@dschneider-pivotal @sabbey37
+geode-core/**/org/apache/geode/compression/**                     
@dschneider-pivotal @sabbey37

Review comment:
       On the compression I suggest changing sabbey37 to kirklund

##########
File path: CODEOWNERS
##########
@@ -0,0 +1,309 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#-----------------------------------------------------------------
+# CODEOWNERS and .asf.yml - owned by everyone
+#-----------------------------------------------------------------
+CODEOWNERS @apache/geode-committers
+.asf.yml @apache/geode-committers
+ 
+#-----------------------------------------------------------------
+# Serialization
+#-----------------------------------------------------------------
+geode-serialization/**                                            @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/pdx/**                             
@upthewaterspout @dschneider-pivotal
+geode-core/**/org/apache/geode/internal/*                         @bschuchardt 
@Bill
+
+#-----------------------------------------------------------------
+# Membership
+#-----------------------------------------------------------------
+geode-membership/**                                               @bschuchardt 
@Bill
+geode-old-client-support/**                                       @bschuchardt 
@Bill
+geode-tcp-server/**                                               @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/internal/membership/** @bschuchardt 
@Bill
+
+#-----------------------------------------------------------------
+# P2P Messaging
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/tcp/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/internal/direct/**     @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/internal/net/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/net/**                             @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/*                      @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/internal/*             @bschuchardt 
@Bill
+
+#-----------------------------------------------------------------
+# Client/server messaging and cache operations
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/cache/client/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/cache/server/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/internal/cache/client/**           @bschuchardt 
@echobravopapa
+geode-core/**/org/apache/geode/internal/cache/tier/**             @bschuchardt 
@echobravopapa
+
+#-----------------------------------------------------------------
+# Client Queues
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/ha/**               @agingade 
@boglesby
+geode-core/**/org/apache/geode/internal/cache/tier/CacheClient*   @agingade 
@boglesby
+ 
+#-----------------------------------------------------------------
+# Experimental Protobuf based Client/Server
+#-----------------------------------------------------------------
+#geode-experimental-driver/**
+#geode-protobuf/**
+#geode-protobuf-messages/**
+
+#-----------------------------------------------------------------
+# Core Public API packages - Cache, Region, etc.
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/*                                  
@dschneider-pivotal @boglesby
+geode-core/**/org/apache/geode/cache/*                            
@dschneider-pivotal @boglesby
+geode-core/**/org/apache/geode/cache/util/**                      
@dschneider-pivotal @boglesby
+
+#-----------------------------------------------------------------
+# Distributed Locks
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/distributed/internal/locks/**      @kirklund 
@dschneider-pivotal
+
+#-----------------------------------------------------------------
+# Core region implementations and plumbing
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/*                   @nabarunnag 
@DonalEvans @jchen21
+
+#-----------------------------------------------------------------
+# Region entry management
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/entries/**          
@dschneider-pivotal @sabbey37
+geode-core/**/org/apache/geode/internal/cache/region/entry/**     
@dschneider-pivotal @sabbey37
+geode-core/**/org/apache/geode/internal/cache/map/**              
@dschneider-pivotal @sabbey37
+geode-core/**/org/apache/geode/compression/**                     
@dschneider-pivotal @sabbey37
+geode-core/**/org/apache/geode/internal/cache/compression/**      
@dschneider-pivotal @sabbey37
+
+#-----------------------------------------------------------------
+# Partitioned Regions
+#-----------------------------------------------------------------
+geode-rebalancer/**                                               @boglesby 
@BenjaminPerryRoss
+geode-core/**/org/apache/geode/internal/cache/partitioned/**      @boglesby 
@BenjaminPerryRoss
+geode-core/**/org/apache/geode/cache/partition/**                 @boglesby 
@BenjaminPerryRoss
+
+#-----------------------------------------------------------------
+# Event tracking
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/event/**            @agingade 
@nabarunnag @gesterzhou
+
+#-----------------------------------------------------------------
+# Eviction
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/eviction/**         @agingade 
@dschneider-pivotal
+geode-core/**/org/apache/geode/internal/size/**                   @agingade 
@dschneider-pivotal
+
+#-----------------------------------------------------------------
+# Offheap
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/offheap/**                
@pivotal-eshu @dschneider-pivotal
+
+#-----------------------------------------------------------------
+# Transactions
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/tx/**               
@pivotal-eshu @gesterzhou
+geode-core/**/org/apache/geode/internal/jta/**                    
@pivotal-eshu @gesterzhou
+geode-core/**/org/apache/geode/internal/cache/locks/**            
@pivotal-eshu @gesterzhou
+
+#-----------------------------------------------------------------
+# Function Execution
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/execute/**          @boglesby 
@sabbey37
+geode-core/**/org/apache/geode/cache/execute/**                   @boglesby 
@sabbey37
+
+#-----------------------------------------------------------------
+# Querying
+#-----------------------------------------------------------------
+geode-cq/**                                                       @nabarunnag 
@DonalEvans
+geode-core/**/org/apache/geode/cache/query/**                     @nabarunnag 
@DonalEvans
+
+#-----------------------------------------------------------------
+# Session State:
+#-----------------------------------------------------------------
+extensions/**                                                     @sabbey37 
@jdeppe-pivotal @BenjaminPerryRoss
+geode-core/**/org/apache/geode/internal/modules/util/**           @sabbey37 
@jdeppe-pivotal @BenjaminPerryRoss
+
+#-----------------------------------------------------------------
+# DEV rest API
+#-----------------------------------------------------------------
+geode-web-api/**                                                  
@jdeppe-pivotal @jinmeiliao
+
+#-----------------------------------------------------------------
+# Lucene integration
+#-----------------------------------------------------------------
+geode-lucene/**                                                   @nabarunnag 
@DonalEvans
+
+#-----------------------------------------------------------------
+# Memcached integration
+#-----------------------------------------------------------------
+geode-memcached/**                                                @nabarunnag 
@DonalEvans
+
+#-----------------------------------------------------------------
+# Misc Utilities
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/util/concurrent/**        @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/internal/shared/**                 @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/internal/sequencelog/**            @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/internal/concurrent/**             @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/distributed/internal/unsafe/**     @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/internal/lang/**                   @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/internal/monitoring/**             @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/internal/exception/**              @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/lang/**                            @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/ra/**                              @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/internal/util/**                   @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/internal/cache/vmotion/**          @nabarunnag 
@boglesby
+geode-core/**/org/apache/geode/internal/jndi/**                   @nabarunnag 
@boglesby
+geode-common/**                                                   @nabarunnag 
@boglesby
+geode-unsafe/**                                                   @nabarunnag 
@boglesby
+
+#-----------------------------------------------------------------
+# Persistence
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/cache/persistence/**               @kirklund 
@dschneider-pivotal @jchen21
+geode-core/**/org/apache/geode/internal/cache/persistence/**      @kirklund 
@dschneider-pivotal @jchen21
+geode-core/**/org/apache/geode/internal/cache/backup/**           @kirklund 
@dschneider-pivotal @agingade @jchen21
+
+#-----------------------------------------------------------------
+# Region Version Vectors - used for sychronization on 
+# member failures and persistent recovery
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/versions/**         
@dschneider-pivotal @gesterzhou

Review comment:
       I suggest you change dschneider to bruce

##########
File path: CODEOWNERS
##########
@@ -0,0 +1,309 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#-----------------------------------------------------------------
+# CODEOWNERS and .asf.yml - owned by everyone
+#-----------------------------------------------------------------
+CODEOWNERS @apache/geode-committers
+.asf.yml @apache/geode-committers
+ 
+#-----------------------------------------------------------------
+# Serialization
+#-----------------------------------------------------------------
+geode-serialization/**                                            @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/pdx/**                             
@upthewaterspout @dschneider-pivotal
+geode-core/**/org/apache/geode/internal/*                         @bschuchardt 
@Bill
+
+#-----------------------------------------------------------------
+# Membership
+#-----------------------------------------------------------------
+geode-membership/**                                               @bschuchardt 
@Bill
+geode-old-client-support/**                                       @bschuchardt 
@Bill
+geode-tcp-server/**                                               @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/internal/membership/** @bschuchardt 
@Bill
+
+#-----------------------------------------------------------------
+# P2P Messaging
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/tcp/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/internal/direct/**     @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/internal/net/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/net/**                             @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/*                      @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/distributed/internal/*             @bschuchardt 
@Bill
+
+#-----------------------------------------------------------------
+# Client/server messaging and cache operations
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/cache/client/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/cache/server/**                    @bschuchardt 
@Bill
+geode-core/**/org/apache/geode/internal/cache/client/**           @bschuchardt 
@echobravopapa
+geode-core/**/org/apache/geode/internal/cache/tier/**             @bschuchardt 
@echobravopapa
+
+#-----------------------------------------------------------------
+# Client Queues
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/ha/**               @agingade 
@boglesby
+geode-core/**/org/apache/geode/internal/cache/tier/CacheClient*   @agingade 
@boglesby
+ 
+#-----------------------------------------------------------------
+# Experimental Protobuf based Client/Server
+#-----------------------------------------------------------------
+#geode-experimental-driver/**
+#geode-protobuf/**
+#geode-protobuf-messages/**
+
+#-----------------------------------------------------------------
+# Core Public API packages - Cache, Region, etc.
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/*                                  
@dschneider-pivotal @boglesby
+geode-core/**/org/apache/geode/cache/*                            
@dschneider-pivotal @boglesby
+geode-core/**/org/apache/geode/cache/util/**                      
@dschneider-pivotal @boglesby
+
+#-----------------------------------------------------------------
+# Distributed Locks
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/distributed/internal/locks/**      @kirklund 
@dschneider-pivotal
+
+#-----------------------------------------------------------------
+# Core region implementations and plumbing
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/*                   @nabarunnag 
@DonalEvans @jchen21
+
+#-----------------------------------------------------------------
+# Region entry management
+#-----------------------------------------------------------------
+geode-core/**/org/apache/geode/internal/cache/entries/**          
@dschneider-pivotal @sabbey37

Review comment:
       On the entry and map code I suggest changing sabbey37 to Bruce or Dan




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to