pivotal-jbarrett commented on a change in pull request #717:
URL: https://github.com/apache/geode-native/pull/717#discussion_r553679152
##########
File path: dependencies/ACE/CMakeLists.txt
##########
@@ -82,6 +82,7 @@ if (${WIN32})
set ( _CONFIGURE_COMMAND ${_COMMAND_PREFIX}
${CMAKE_COMMAND} -E env ACE_ROOT=<SOURCE_DIR>
SSL_ROOT=${OPENSSL_ROOT}
${MPC} ${MPC_FLAGS}
-name_modifier "*_${_TYPE}_static" -static
+ -value_template
WindowsTargetPlatformVersion=${CMAKE_SYSTEM_VERSION}
Review comment:
Does not match formatting of the surrounding lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
