pivotal-jbarrett commented on a change in pull request #723:
URL: https://github.com/apache/geode-native/pull/723#discussion_r561246098



##########
File path: cppcache/integration/test/CMakeLists.txt
##########
@@ -53,11 +55,15 @@ add_executable(cpp-integration-test
   SslTwoWayTest.cpp
   StructTest.cpp
   TransactionCleaningTest.cpp
-  WanDeserializationTest.cpp
-  PdxInstanceFactoryTest.cpp
-  CacheWriterTest.cpp
   TransactionsTest.cpp
+  WanDeserializationTest.cpp
 )
+if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+  target_compile_options(cpp-integration-test
+    PUBLIC
+      -Wno-used-but-marked-unused

Review comment:
       Is this only in a single test? Perhaps we can just add it as a `#pragma` 
to that file or eve suppress the single line. Worst case we could add this as 
an option to just that tests cpp file options.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to