jhutchison commented on a change in pull request #5939: URL: https://github.com/apache/geode/pull/5939#discussion_r562121090
########## File path: geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/hash/HstrlenDUnitTest.java ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.geode.redis.internal.executor.hash; + +import static org.assertj.core.api.Assertions.assertThat; + +import java.util.Random; + +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Test; +import redis.clients.jedis.Jedis; + +import org.apache.geode.redis.ConcurrentLoopingThreads; +import org.apache.geode.test.awaitility.GeodeAwaitility; +import org.apache.geode.test.dunit.rules.MemberVM; +import org.apache.geode.test.dunit.rules.RedisClusterStartupRule; + +public class HstrlenDUnitTest { + + @ClassRule + public static RedisClusterStartupRule clusterStartUp = new RedisClusterStartupRule(4); + + private static final String LOCAL_HOST = "127.0.0.1"; + private static final int JEDIS_TIMEOUT = + Math.toIntExact(GeodeAwaitility.getTimeout().toMillis()); + private static Jedis jedis1; + private static Jedis jedis2; + private static Jedis jedis3; + + @BeforeClass + public static void classSetup() { + MemberVM locator = clusterStartUp.startLocatorVM(0); + clusterStartUp.startRedisVM(1, locator.getPort()); + clusterStartUp.startRedisVM(2, locator.getPort()); + + int redisServerPort1 = clusterStartUp.getRedisPort(1); + int redisServerPort2 = clusterStartUp.getRedisPort(2); + + jedis1 = new Jedis(LOCAL_HOST, redisServerPort1, JEDIS_TIMEOUT); + jedis2 = new Jedis(LOCAL_HOST, redisServerPort2, JEDIS_TIMEOUT); + jedis3 = new Jedis(LOCAL_HOST, redisServerPort1, JEDIS_TIMEOUT); + } + + @Before + public void testSetup() { + jedis1.flushAll(); + } + + @Test + public void hstrlenWorks_whileAlsoUpdatingHash() { + String key = "key"; + String field = "field"; + int iterations = 10000; + Random rand = new Random(); + + jedis1.hset(key, field, "22"); + + new ConcurrentLoopingThreads(iterations, + (i) -> { + int newLength = rand.nextInt(9) + 1; + String newVal = makeStringOfRepeatedDigits(newLength); + jedis1.hset(key, field, newVal); + }, + (i) -> assertThat(jedis2.hstrlen(key, field)).isBetween(1L, 9L), + (i) -> assertThat(jedis3.hstrlen(key, field)).isBetween(1L, 9L)) + .run(); + + String value = jedis1.hget(key, field); + int expectedLength = Integer.parseInt(Character.toString(value.charAt(0))); Review comment: this line seemed pretty confusing to me when I looked at it. Maybe there is some way to express that the value is comprised of the digit which is also supposed to be it's length? Or maybe just a comment (in general I'm not a fan, but sometimes....) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
