sabbey37 commented on a change in pull request #5949:
URL: https://github.com/apache/geode/pull/5949#discussion_r564667114
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
##########
@@ -181,6 +181,7 @@
***************************************/
// do not call these directly, only to be used in other commands
INTERNALPTTL(null, INTERNAL, new ExactParameterRequirements(2)),
+ INTERNALTYPE(null, INTERNAL, new ExactParameterRequirements(2)),
INTERNALSMEMBERS(null, INTERNAL, new ExactParameterRequirements(3)),
Review comment:
Is it weird that a user would be able to call these from the CLI and
would get different error messages if they did (like "wrong number of
arguments" or "server had an internal error" instead of "unknown command"
error)? Not sure why they would and maybe it doesn't really matter. I guess
I'm just wondering if there's a way of preventing that or some other way of
doing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
