kirklund commented on a change in pull request #5953:
URL: https://github.com/apache/geode/pull/5953#discussion_r564738006
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/InternalRegion.java
##########
@@ -449,6 +450,8 @@ default void unlockWhenRegionIsInitializing() {
CachePerfStats getRegionPerfStats();
+ void handleInterestEvent(InterestRegistrationEvent event);
Review comment:
Yes, I think it's ok to make this public. Users can already use
Reflection to invoke non-public methods on LocalRegion anyway. My overall
method is this:
1. switch over to using interfaces for all dependencies and interactions
between classes
2. use dependency injection to make unit testing easy
3. review the interfaces and break up larger ones to better represent the
actual dependencies/interactions between packages or components
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
