pivotal-jbarrett commented on a change in pull request #5947:
URL: https://github.com/apache/geode/pull/5947#discussion_r564796702



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
##########
@@ -1347,14 +1304,10 @@ private static void handleRegEx(LocalRegion region, 
String regex, InterestResult
    */
   private static void handleRegExPR(final PartitionedRegion region, final 
String regex,
       final InterestResultPolicy policy, final ServerConnection servConn) 
throws IOException {
-    final List keyList = new ArrayList(MAXIMUM_CHUNK_SIZE);
+    final List<Object> keyList = new ArrayList<>(MAXIMUM_CHUNK_SIZE);
     region.getKeysWithRegEx(regex, sendTombstonesInRIResults(servConn, policy),
-        new PartitionedRegion.SetCollector() {
-          @Override
-          public void receiveSet(Set theSet) throws IOException {
-            appendInterestResponseKeys(region, regex, theSet, keyList, 
servConn);
-          }
-        });
+        theSet -> appendInterestResponseKeys(region, regex, 
uncheckedCast(theSet), keyList,

Review comment:
       Yes, IJ wants concise readable code. I subscribe to the same.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to