onichols-pivotal commented on a change in pull request #5967:
URL: https://github.com/apache/geode/pull/5967#discussion_r565907930
##########
File path: geode-common/build.gradle
##########
@@ -26,6 +26,7 @@ dependencies {
implementation(platform(project(':boms:geode-all-bom')))
implementation('com.fasterxml.jackson.core:jackson-databind')
+ api('org.jetbrains:annotations')
Review comment:
https://github.com/JetBrains/java-annotations suggests `compileOnly`
rather than `api` ... is the intent to ship jetbrains annotations .jar with
Geode, or use it only at compile time? I could see arguments either way (or
maybe for technical reasons we don't actually have a choice?), just want to be
sure we get the right scope because scopes are tricky. @rhoughton-pivot any
thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
