pivotal-eshu commented on a change in pull request #5901:
URL: https://github.com/apache/geode/pull/5901#discussion_r566447639
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tx/DistributedTXRegionStub.java
##########
@@ -120,12 +137,11 @@ public boolean containsKey(KeyInfo keyInfo) {
}
}
-
@Override
public boolean containsValueForKey(KeyInfo keyInfo) {
try {
- RemoteContainsKeyValueResponse response = RemoteContainsKeyValueMessage
- .send((InternalDistributedMember) state.getTarget(), region,
keyInfo.getKey(), true);
+ RemoteContainsKeyValueResponse response =
sendRemoteContainsKeyValueMessage(
+ (InternalDistributedMember) state.getTarget(), keyInfo.getKey());
Review comment:
The method lost valueCheck (true) value with the current method
implementation.
RemoteContainsKeyValueResponse send(InternalDistributedMember recipient,
LocalRegion r, Object key, boolean valueCheck)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
