onichols-pivotal edited a comment on pull request #5828:
URL: https://github.com/apache/geode/pull/5828#issuecomment-770501970


   @jinmei it looks like the test 
DistributedSystemMBeanIntegrationTest.queryAllUsingGfshDoesNotFormatDate was 
expecting LocalDate objects to be serialized as POJOs (i.e. the test expects to 
see the internal serialized fields of a LocalDate object).  Jackson 2.12 no 
longer allows that.  I've updated the test to instead expect the new failure 
message.  Is this an acceptable change in default behavior?
   
   Perhaps better would be to start including the jsr310 jar in the shipping 
product, instead of as test-runtime-only dependency, so that date formatting 
always displays *something* out-of-the-box?  LocalDate is a built-in type in 
JDK8 and the only reason Jackson breaks it out as a separate module is for JDK7 
compatibility of jackson-core.  But since Geode is minimum JDK8, perhaps it 
makes us look bad if we don't support standard JDK8 date/time types...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to