pivotal-jbarrett commented on a change in pull request #705:
URL: https://github.com/apache/geode-native/pull/705#discussion_r567922837
##########
File path: cppcache/integration/framework/Cluster.cpp
##########
@@ -161,7 +163,7 @@ Server::Server(Cluster &cluster, std::vector<Locator>
&locators,
hostname = "ip6-localhost";
}
- auto port = static_cast<uint16_t>(0);
+ auto port = Framework::getAvailablePort();
Review comment:
Geode server will select its own ephemeral port if we send 0. We should
preserve this default behavior in the tests. If you test needs to know the
specific port of the server then that test should use this method to get a free
port and assign it to the server in the cluster config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
