nonbinaryprogrammer commented on a change in pull request #5988:
URL: https://github.com/apache/geode/pull/5988#discussion_r569768113
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/hash/AbstractHashesIntegrationTest.java
##########
@@ -344,31 +336,40 @@ public void incrByFloatFailsWithNonFloatFieldValue() {
}
@Test
- public void testHExists() {
- String key = Double.valueOf(rand.nextDouble()).toString();
- String field = Double.valueOf(rand.nextInt(50)).toString() + ".field";
- String value = Double.valueOf(rand.nextInt(50)).toString() + ".value";
-
- assertThat(jedis.hexists(key, field)).isFalse();
+ public void testHExists_isFalseForNonexistentKeyOrField() {
+ jedis.hset("key", "field", "value");
- jedis.hset(key, field, value);
-
- assertThat(jedis.hget(key, field)).isEqualTo(value);
-
- assertThat(jedis.hexists(key, field)).isTrue();
+ assertThat(jedis.hexists("nonexitentKey", "someField")).isFalse();
Review comment:
>.< oops. I think I'll go ahead and merge it and fix it in my next PR.
don't want to send it back through CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
