ringles commented on a change in pull request #5978:
URL: https://github.com/apache/geode/pull/5978#discussion_r571044531



##########
File path: geode-core/src/main/java/org/apache/geode/Delta.java
##########
@@ -55,7 +55,20 @@
   void fromDelta(DataInput in) throws IOException, InvalidDeltaException;
 
   /**
-   * Allows Delta implementations to ensure bucket sizes are recalculated 
after delta is applied
+   * By default, buckets do not recalculate their size when deltas are 
applied. This optimizes for
+   * the case where the sie of an entry does not change. However, if the size 
does increase or
+   * decrease, this default behavior can result in the memory usage statistics 
becoming inaccurate.
+   *
+   * There is a global Geode property, DELTAS_RECALCULATE_SIZE, which can be 
used to cause all

Review comment:
       New version of comment up.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to