echobravopapa commented on a change in pull request #741:
URL: https://github.com/apache/geode-native/pull/741#discussion_r571166040
##########
File path: clicache/src/impl/PdxHelper.hpp
##########
@@ -46,15 +46,15 @@ namespace Apache
static IPdxSerializable^ DeserializePdx(DataInput^ dataOutput, bool
forceDeserialize, const native::SerializationRegistry* serializationRegistry);
- static IPdxSerializable^ PdxHelper::DeserializePdx(DataInput^
dataInput, bool forceDeserialize, int typeId, int length, const
native::SerializationRegistry* serializationRegistry);
+ static IPdxSerializable^ DeserializePdx(DataInput^ dataInput, bool
forceDeserialize, int typeId, int length, const native::SerializationRegistry*
serializationRegistry);
literal Byte PdxHeader = 8;
static Int32 ReadInt32(System::Byte* offsetPosition);
static Int32 ReadInt16(System::Byte* offsetPosition);
- static Int32
PdxHelper::ReadUInt16(System::Byte* offsetPosition);
+ static Int32 ReadUInt16(System::Byte*
offsetPosition);
Review comment:
please fix this - its a pain that just continues if we don't keep it
tidy...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
