bschuchardt commented on a change in pull request #5987:
URL: https://github.com/apache/geode/pull/5987#discussion_r571279904
##########
File path:
geode-core/src/integrationTest/java/org/apache/geode/internal/net/SocketCloserIntegrationTest.java
##########
@@ -113,26 +113,34 @@ public void testAsync() {
* Verify that requesting an asyncClose on an already closed socket is a
noop.
*/
@Test
- public void testClosedSocket() throws Exception {
- final AtomicBoolean runnableCalled = new AtomicBoolean();
+ public void testOpenSocketCloser() {
+ final AtomicBoolean beforeSocketCloseRunnableWasCalled = new
AtomicBoolean();
+ final AtomicBoolean afterSocketCloseRunnableWasCalled = new
AtomicBoolean();
- Socket s = createClosableSocket();
- s.close();
- this.socketCloser.asyncClose(s, "A", () -> runnableCalled.set(true));
- await().until(() -> !runnableCalled.get());
+ final Socket closableSocket = createClosableSocket();
+ this.socketCloser.asyncClose(closableSocket, "A",
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
