Bill opened a new pull request #6027:
URL: https://github.com/apache/geode/pull/6027
@kamilla1201 and I were having some trouble reasoning about whether
synchronization might be needed in `GMSMembership.memberExists()` because it
calls `MembershipView<ID>.contains(ID)` and that membership view can be mutable
("modifiable".)
Upon examination, there was no pressing need for `MembershipView` to support
modification at all. So I did this little experiment to see if I could make
that thing fully immutable. So here it is. Let's see what CI says.
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
