albertogpz commented on a change in pull request #6028:
URL: https://github.com/apache/geode/pull/6028#discussion_r578981283
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java
##########
@@ -1555,6 +1555,9 @@ private void applyProjection(boolean add,
ExecutionContext context)
throws FunctionDomainException, TypeMismatchException,
NameResolutionException,
QueryInvocationTargetException, IMQException {
Object indexKey = indexedExpr.evaluate(context);
+ if (IndexManager.NULL.equals(indexKey)) {
+ return;
+ }
if (indexKey == null) {
Review comment:
Yes. This is left for the case when we are adding an entry (we are not
querying) and the map does not contain the key (line 114 in
CompiledIndexOperation). In that case, we don't add the index.
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java
##########
@@ -1555,6 +1555,9 @@ private void applyProjection(boolean add,
ExecutionContext context)
throws FunctionDomainException, TypeMismatchException,
NameResolutionException,
QueryInvocationTargetException, IMQException {
Object indexKey = indexedExpr.evaluate(context);
+ if (IndexManager.NULL.equals(indexKey)) {
+ return;
+ }
if (indexKey == null) {
Review comment:
Yes. This is left for the case when we are adding an entry (we are not
querying) and the map does not contain the key (line 114 in
CompiledIndexOperation.java). In that case, we don't add the index.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
