bschuchardt commented on a change in pull request #6037:
URL: https://github.com/apache/geode/pull/6037#discussion_r582353925
##########
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMembership.java
##########
@@ -1360,13 +1319,8 @@ public boolean verifyMember(ID mbr, String reason) {
@Override
public ID[] getAllMembers(final ID[] arrayType) {
- latestViewReadLock.lock();
- try {
- List<ID> keySet = latestView.getMembers();
- return keySet.toArray(arrayType);
- } finally {
- latestViewReadLock.unlock();
- }
+ final List<ID> keySet = latestView.getMembers();
Review comment:
The lock is protecting new view formation in processView(). This data
needs to be stable while the new view is created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
