gaussianrecurrence commented on a change in pull request #715:
URL: https://github.com/apache/geode-native/pull/715#discussion_r582908949
##########
File path: cppcache/src/ClientMetadataService.cpp
##########
@@ -59,9 +59,11 @@ void ClientMetadataService::start() {
}
void ClientMetadataService::stop() {
- m_run = false;
- m_regionQueueCondition.notify_one();
- m_thread.join();
+ if (m_run) {
Review comment:
As I changed the testing, this is now not currently needed. For the
purpose of maintaining the change as minimal as possible, this is left out of
the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
