jhutchison commented on a change in pull request #5954:
URL: https://github.com/apache/geode/pull/5954#discussion_r583015637
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/data/RedisHash.java
##########
@@ -46,19 +52,68 @@
public class RedisHash extends AbstractRedisData {
public static final RedisHash NULL_REDIS_HASH = new NullRedisHash();
private HashMap<ByteArrayWrapper, ByteArrayWrapper> hash;
+ private ConcurrentHashMap<UUID, List<ByteArrayWrapper>> hScanSnapShots;
+ private ConcurrentHashMap<UUID, Long> hScanSnapShotCreationTimes;
+ private ScheduledExecutorService HSCANSnapshotExpirationExecutor = null;
+ private final int HSCAN_SNAPSHOTS_EXPIRE_CHECK_FREQUENCY_MILLISECONDS;
+ private final int MINIMUM_MILLISECONDS_FOR_HSCAN_SNAPSHOTS_TO_LIVE;
+
+ // for serialization
+ public RedisHash() {
+ this.hash = new HashMap<>();
+ this.hScanSnapShots = new ConcurrentHashMap<>();
+ this.hScanSnapShotCreationTimes = new ConcurrentHashMap<>();
+
+ this.HSCAN_SNAPSHOTS_EXPIRE_CHECK_FREQUENCY_MILLISECONDS =
+ Integer.getInteger("redis.hscan-snapshot-cleanup-interval", 30000);
+
+ this.MINIMUM_MILLISECONDS_FOR_HSCAN_SNAPSHOTS_TO_LIVE =
+ Integer.getInteger("redis.hscan-snapshot-expiry", 30000);
Review comment:
ok- reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
