kirklund commented on a change in pull request #6044:
URL: https://github.com/apache/geode/pull/6044#discussion_r583876477
##########
File path:
geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommandDUnitTestBase.java
##########
@@ -200,6 +212,14 @@ private static void prepareDataForRegion(String
regionPath) {
}
}
+ private static void prepareDataForRegionWithSpecialCharacters(String
regionPath) {
+ InternalCache cache = ClusterStartupRule.getCache();
+ Region dataRegion = cache.getRegion(regionPath);
Review comment:
Don't worry about the other lines in this old class that use raw types.
##########
File path:
geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommandDUnitTestBase.java
##########
@@ -200,6 +212,14 @@ private static void prepareDataForRegion(String
regionPath) {
}
}
+ private static void prepareDataForRegionWithSpecialCharacters(String
regionPath) {
+ InternalCache cache = ClusterStartupRule.getCache();
+ Region dataRegion = cache.getRegion(regionPath);
Review comment:
Please try to use non-raw types in places like this. There's an IntelliJ
inspection you can enable that'll highlight lines like this:
```
Region<Integer, String> dataRegion = cache.getRegion(regionPath);
dataRegion.put(1, "value$");
dataRegion.put(2, "value%");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
