pdxcodemonkey commented on a change in pull request #754:
URL: https://github.com/apache/geode-native/pull/754#discussion_r585704872
##########
File path: ci/lib/templates.lib.txt
##########
@@ -90,7 +90,7 @@ run-clang-tidy -j $(nproc) -quiet
(@ def clang_format_bash_task(): -@)
set -ueo pipefail
-export GEODE_HOME=$(pwd)/geode/expanded/apache-geode-$(cat geode/version)
+export GEODE_HOME=$(pwd)/geode
Review comment:
Why set GEODE_HOME here, and use -DGEODE_ROOT in cmake configure line
below? It'd be great to do this consistently, probably using cmake variable in
both cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
