sabbey37 commented on a change in pull request #5954:
URL: https://github.com/apache/geode/pull/5954#discussion_r583045619
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/hash/AbstractHScanIntegrationTest.java
##########
@@ -237,15 +316,40 @@ public void
givenMultipleCounts_returnsAllEntriesWithoutDuplicates() {
String cursor = "0";
do {
- result = (List<Object>) jedis.sendCommand(Protocol.Command.HSCAN,
"colors", cursor, "COUNT",
- "2", "COUNT", "1");
+ result = (List<Object>) jedis.sendCommand(Protocol.Command.HSCAN,
+ "colors",
+ cursor,
+ "COUNT", "2",
+ "COUNT", "1");
+
allEntries.addAll((List<byte[]>) result.get(1));
cursor = new String((byte[]) result.get(0));
} while (!Arrays.equals((byte[]) result.get(0), "0".getBytes()));
assertThat((byte[]) result.get(0)).isEqualTo("0".getBytes());
- assertThat(allEntries).containsExactlyInAnyOrder("1".getBytes(),
"yellow".getBytes(),
- "12".getBytes(), "green".getBytes(), "3".getBytes(),
"grey".getBytes());
Review comment:
I know this was removed entirely, but maybe we could just change this to
check that all the expected elements are there (`.containsAll()`)... since
there may be duplicates, but it is guaranteed that all elements present for the
full iteration will be returned at least once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
